[10] RFR(XS): 8180473: Use proper deallocation for FileBuff::_bigbuf

[Zoltán Majó]

Hi Thomas,


On 05/18/2017 08:47 PM, Thomas Stüfe wrote:
> Hi Zoltan,
>
> looks good. Old code may have worked but relied on undefined behaviour.

thank you for the review.

Unfortunately, the fix was already in the repo when your mail arrived, 
so I am not able to mention you as a reviewer. Sorry for that.

Best regards,


Zoltan

>
> Kind Regards, Thomas
>
> On Wed, May 17, 2017 at 12:52 PM, Zoltán Majó <zoltan.majo at oracle.com 
> <mailto:zoltan.majo at oracle.com>> wrote:
>
>     Hi,
>
>
>     please review the following fix for 8180473.
>     https://bugs.openjdk.java.net/browse/JDK-8180473
>     <https://bugs.openjdk.java.net/browse/JDK-8180473>
>     http://cr.openjdk.java.net/~zmajo/8180473/webrev.00/
>     <http://cr.openjdk.java.net/%7Ezmajo/8180473/webrev.00/>
>
>     It is a good coding practice to properly deallocate dynamically
>     allocated resources. In particular, dynamically allocated memory
>     for arrays using the array-specific new[] operator is supposed to
>     be deallocated using the array-specific delete[] operator. The
>     deallocation of FileBuff::_bigbuf does not follow this
>     recommendation and should therefore be changed. Tested with JPRT.
>
>     Thank you!
>
>     Best regards,
>
>
>     Zoltan
>
>