[9] RFR(XS): 8180855: Null pointer dereference in OopMapSet::all_do of oopMap.cpp:394

[Zoltán Majó]

Hi Vladimir,


On 05/27/2017 02:25 AM, Vladimir Kozlov wrote:
> Zoltan, you missed webrev link. Is it this one?:
>
> http://cr.openjdk.java.net/~zmajo/8180855/webrev.00/

sorry, I indeed missed the link. You posted the correct link -- thank 
you for digging it up.

> It looks good.

RBT testing looks good, I'll push the fix. Thank you for the review!

Best regards,


Zoltan

>
> Thanks,
> Vladimir
>
> On 5/26/17 4:36 AM, Zoltán Majó wrote:
>> Hi,
>>
>>
>> please review the following fix for 8180855.
>> https://bugs.openjdk.java.net/browse/JDK-8180855
>> https://bugs.openjdk.java.net/browse/JDK-8180855
>>
>> We check if the contents of the memory location returned by 
>> oopmapreg_to_location() is NULL, but we do not check if the memory 
>> location itself is NULL. The fix adds the missing check. JPRT testing 
>> passes, RBT pre-PIT testing is in progress.
>>
>> Thank you!
>>
>> Best regards,
>>
>>
>> Zoltan
>>