[10] JBS: 8167408: Invalid critical JNI function lookup

[Doerr, Martin]

Hi Jamsheed,

seems like this lookup style is not used on all platforms. On PPC64, the test works with and without your fix.
nm only shows:
T Java_compiler_criticalnatives_LookUp_m1
T Java_compiler_criticalnatives_LookUp_m2
T Java_compiler_criticalnatives_LookUp_m3
T JavaCritical_compiler_criticalnatives_LookUp_m1
T JavaCritical_compiler_criticalnatives_LookUp_m2
T JavaCritical_compiler_criticalnatives_LookUp_m3

Anyway, the fix and the test look good to me. I agree with that it makes sense to run in on all platforms.

Best regards,
Martin


-----Original Message-----
From: hotspot-compiler-dev [mailto:hotspot-compiler-dev-bounces at openjdk.java.net] On Behalf Of jamsheed
Sent: Dienstag, 31. Oktober 2017 20:38
To: hotspot-compiler-dev at openjdk.java.net
Subject: Re: [10] JBS: 8167408: Invalid critical JNI function lookup

Hi Dean,

Thank you for the review,

tested with a test case, previously it was not working for windows-x86, 
now it works.

revised webrev with test 
case:http://cr.openjdk.java.net/~jcm/8167408/webrev.01/

Best regards,

Jamsheed


On Tuesday 31 October 2017 02:18 AM, dean.long at oracle.com wrote:
> I think you need a native test for Windows x86 that defines 
> JavaCritical methods with various signatures (especially arrays) to 
> make sure this is working correctly.
>
> dl
>
>
> On 10/30/17 9:45 AM, jamsheed wrote:
>> Hi,
>>
>> request for review,
>>
>> jbs : https://bugs.openjdk.java.net/browse/JDK-8167408
>>
>> webrev: http://cr.openjdk.java.net/~jcm/8167408/webrev.00/
>>
>> (contributed by Ioannis Tsakpinis)
>>
>> desc:
>>
>> -- it starts with JavaCritical_ instead of Java_;
>> -- it does not have extra JNIEnv* and jclass arguments;
>> -- Java arrays are passed in two arguments: the first is an array 
>> length, and the second is a pointer to raw array data. That is, no 
>> need to call GetArrayElements and friends, you can instantly use a 
>> direct array pointer.
>>
>> updated arg_size calculation wrt above points.
>>
>> Best regards,
>>
>> Jamsheed
>>
>