RFR(S): 8190781: ppc64 + s390: Fix CriticalJNINatives

Lindenmaier, Goetz goetz.lindenmaier at sap.com
Mon Nov 6 10:54:13 UTC 2017


HI Martin,

looks good, but please fix this comment to something meaningful before pushing:
(at least I don't grok it :))
// Value is in an input register pass we must flush it to the stack

Thanks,
  Goetz.

> -----Original Message-----
> From: Doerr, Martin
> Sent: Montag, 6. November 2017 11:49
> To: 'hotspot-compiler-dev at openjdk.java.net' <hotspot-compiler-
> dev at openjdk.java.net>; Lindenmaier, Goetz <goetz.lindenmaier at sap.com>
> Subject: RFR(S): 8190781: ppc64 + s390: Fix CriticalJNINatives
> 
> Hi,
> 
> 
> 
> CriticalJNINatives are currently not working correctly on PPC64 and s390.
> Code which saves & restores int type values is missing.
> 
> The s390 implementation needs 2 more minor fixes. Please see my webrev:
> 
> http://cr.openjdk.java.net/~mdoerr/8190781_ppc64_s390_CritNatives/webr
> ev.00/
> <http://cr.openjdk.java.net/~mdoerr/8190781_ppc64_s390_CritNatives/we
> brev.00/>
> 
> 
> 
> I've also fixed an obvious copy&paste bug in PPC64 assembler in a currently
> unused instruction.
> 
> My proposed change also switches off SuperwordUseVSX on PPC64 as
> discussed with Michihiro who is still working on it.
> 
> 
> 
> Please review.
> 
> 
> 
> Best regards,
> 
> Martin
> 
> 



More information about the hotspot-compiler-dev mailing list