[10] RFR: 8191227: issues with unsafe handle resolution

Vladimir Ivanov vladimir.x.ivanov at oracle.com
Thu Nov 23 11:49:05 UTC 2017


> webrev - http://cr.openjdk.java.net/~rraghavan/8191227/webrev.02/

Please, use ThreadInVMfromUnknown in ConstantOopWriteValue::print_on() 
as well.

Otherwise, looks good.

Best regards,
Vladimir Ivanov

> 
> 
> Please check jbs comments -
> jbs - https://bugs.openjdk.java.net/browse/JDK-8191227
>      - related - https://bugs.openjdk.java.net/browse/JDK-8160166
> 
> Fix tried -
> -- ConstantOopWriteValue::write_on()
>      Used ThreadInVMfromUnknown and added required comment.
> -- ConstantOopWriteValue::print_on()
>      found no issue in testing with usage of ThreadInVMfromNative here.
> -- LIR_Assembler::jobject2reg()
>      Similarly used ThreadInVMfromNative, before the assert.
> 
> No new issues with testing - tier1, tier2, tier3, compiler pre-checkin
>   and also jprt (-testset hotspot).
> 
> 
> Thanks,
> Rahul


More information about the hotspot-compiler-dev mailing list