[10] RFR(XS): 8191996: VM startup fails with CodeCacheExpansionSize=32768 is outside the allowed range

Tobias Hartmann tobias.hartmann at oracle.com
Tue Nov 28 17:32:12 UTC 2017


Hi,

please review the following fix:
https://bugs.openjdk.java.net/browse/JDK-8191996
http://cr.openjdk.java.net/~thartmann/8191996/webrev.00/

JDK-8179026 [1] set the minimum CodeCacheExpansionSize to vm_page_size() because in CodeCache::initialize() we align to
page size anyway. However, there are platforms where the default CodeCacheExpansionSize is 32*K which might be <
vm_page_size(). I've fixed this by setting the minimum value to 32*K.

A better fix would be to set the default value to os::vm_page_size() (see [2]) but that would require including
runtime/os.hpp which introduces circular dependencies.

Thanks to Adrian for reporting this [3].

Thanks,
Tobias

[1] http://hg.openjdk.java.net/jdk/hs/rev/7f40c1cdde28
[2] http://cr.openjdk.java.net/~thartmann/8191996/webrev.01/
[3] http://mail.openjdk.java.net/pipermail/hotspot-dev/2017-November/029365.html


More information about the hotspot-compiler-dev mailing list