RFR (S): 8191129 - AARCH64: Invalid value passed to critical JNI function

[dean.long at oracle.com]

Does @requires vm.opt.CriticalJNINatives still work instead of os.arch 
!= "aarch64" (I'm not sure if flags on the @run line are added to "vm.opt")?

If not, looks good.

dl


On 11/30/17 10:22 AM, Dmitry Chuyko wrote:
> http://cr.openjdk.java.net/~dchuyko/8191129/webrev.01/
>
> I think for tests it then will be better to explicitly exclude aarch64 
> until complete feature implementation and to add the flag.
>
> Flag disabling was changed to UNSUPPORTED_OPTION() which also prints a 
> warning in case of manual -XX+.
>
> -Dmitry
>
>
> On 11/29/2017 02:50 PM, Vladimir Ivanov wrote:
>>
>>
>> On 11/29/17 2:16 PM, Vladimir Ivanov wrote:
>>>    if (CriticalJNINatives) {
>>>      warning("CriticalJNINatives aren't supported");
>>>      FLAG_SET_DEFAULT(CriticalJNINatives, false);
>>>    }
>>
>> What I meant is:
>>   if (CriticalJNINatives && !FLAG_IS_DEFAULT(CriticalJNINatives)) {
>>     warning("CriticalJNINatives aren't supported");
>>   }
>>   FLAG_SET_DEFAULT(CriticalJNINatives, false);
>>
>> Sorry for the confusion.
>>
>> Best regards,
>> Vladimir Ivanov
>