RFR(S): 8188857: [s390]: CPU feature detection incomplete

[Schmidt, Lutz]

Thanks, Martin, for reviewing my change.
And yes, please go ahead and remove the assignment before pushing.

Thank you!
Lutz


On 09.10.2017, 11:38, "Doerr, Martin" <martin.doerr at sap.com<mailto:martin.doerr at sap.com>> wrote:

Hi Lutz,

thanks for providing this fix. Looks good.
I’d only like to remove the assignment of used_len from vm_version_s390.cpp because it is neither used nor set to a defined value. I can remove it before pushing if you’re ok with that.

Best regards,
Martin


From: hotspot-compiler-dev [mailto:hotspot-compiler-dev-bounces at openjdk.java.net] On Behalf Of Schmidt, Lutz
Sent: Freitag, 6. Oktober 2017 17:37
To: hotspot-compiler-dev at openjdk.java.net
Subject: RFR(S): 8188857: [s390]: CPU feature detection incomplete

Dear all,

I would like to request reviews for this s390-only bug fix:

Bug:    https://bugs.openjdk.java.net/browse/JDK-8188857
Webrev: http://cr.openjdk.java.net/~lucy/webrevs/8188857.00/index.html

z/Architecture vector instructions require operating system support. Without os support, any attempt to execute such an instruction results in a SIGFPE signal. The presence of such support cannot be checked for by inspecting the cpu’s facility bits alone.

During startup, a vector instruction is attempted to execute and, in case of a SIGFPE, the vector facility is marked unavailable.

Thank you!
Lutz




Dr. Lutz Schmidt | SAP JVM | PI  SAP CP Core | T: +49 (6227) 7-42834

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20171009/f02d8095/attachment-0001.html>