RFR: 8171853: Remove Shark compiler

David Holmes david.holmes at oracle.com
Sun Oct 15 21:44:04 UTC 2017


On 16/10/2017 7:39 AM, Roman Kennke wrote:
> Am 15.10.2017 um 23:25 schrieb David Holmes:
>> On 16/10/2017 7:01 AM, Roman Kennke wrote:
>>> Hi David,
>>>
>>> thanks!
>>>
>>> I'm uploading a 2nd revision of the patch that excludes the 
>>> generated-configure.sh part, and adds a smallish Zero-related fix.
>>>
>>> http://cr.openjdk.java.net/~rkennke/8171853/webrev.01/ 
>>> <http://cr.openjdk.java.net/%7Erkennke/8171853/webrev.01/>
>>
>> Can you point me to the exact change please as I don't want to 
>> re-examine it all. :)
> Oops, sorry. The diff between 00 and 01 is this (apart from 
> generated-configure.sh):
> 
> diff --git a/src/hotspot/share/utilities/vmError.cpp 
> b/src/hotspot/share/utilities/vmError.cpp
> --- a/src/hotspot/share/utilities/vmError.cpp
> +++ b/src/hotspot/share/utilities/vmError.cpp
> @@ -192,6 +192,7 @@
>       st->cr();
> 
>       // Print the frames
> +    StackFrameStream sfs(jt);
>       for(int i = 0; !sfs.is_done(); sfs.next(), i++) {
>         sfs.current()->zero_print_on_error(i, st, buf, buflen);
>         st->cr();
> 
> I.e. I added back the sfs variable that I accidentally removed in 
> webrev.00.

Looks good!

David


More information about the hotspot-compiler-dev mailing list