[10] JBS: 8167408: Invalid critical JNI function lookup

dean.long at oracle.com dean.long at oracle.com
Mon Oct 30 20:48:46 UTC 2017


I think you need a native test for Windows x86 that defines JavaCritical 
methods with various signatures (especially arrays) to make sure this is 
working correctly.

dl


On 10/30/17 9:45 AM, jamsheed wrote:
> Hi,
>
> request for review,
>
> jbs : https://bugs.openjdk.java.net/browse/JDK-8167408
>
> webrev: http://cr.openjdk.java.net/~jcm/8167408/webrev.00/
>
> (contributed by Ioannis Tsakpinis)
>
> desc:
>
> -- it starts with JavaCritical_ instead of Java_;
> -- it does not have extra JNIEnv* and jclass arguments;
> -- Java arrays are passed in two arguments: the first is an array 
> length, and the second is a pointer to raw array data. That is, no 
> need to call GetArrayElements and friends, you can instantly use a 
> direct array pointer.
>
> updated arg_size calculation wrt above points.
>
> Best regards,
>
> Jamsheed
>



More information about the hotspot-compiler-dev mailing list