RFR(S): 8201368: IfNode::fold_compares() may lead to incorrect execution

Vladimir Kozlov vladimir.kozlov at oracle.com
Mon Apr 23 18:47:57 UTC 2018


On 4/23/18 12:52 AM, Roland Westrelin wrote:
> 
> Hi Vladimir,
> 
>> Changes looks good.
> 
> Thanks for the review.
> 
>> To avoid running test with -Xcomp add:
>>
>> @requires vm.compMode == "Xmixed"
> 
> Does it really matter for such a simple test case?

I misread your discussion with Nils thinking there was problem to run 
the test with -Xcomp.
If it does not have problems then it is fine.

Please, re-base changes to jdk/jdk, run jdk-submit testing before push.

Thanks,
Vladimir

> 
> Roland.
> 


More information about the hotspot-compiler-dev mailing list