[aarch64-port-dev ] RFR 8202186: AArch64: Debug build VM crashes with PrintC1Statistics option

Ningsheng Jian Ningsheng.Jian at arm.com
Sat Apr 28 10:42:03 UTC 2018


Hi Andrew,

> -----Original Message-----
> From: Andrew Haley <aph at redhat.com>
> Sent: Friday, April 27, 2018 9:24 PM
> To: Ningsheng Jian <Ningsheng.Jian at arm.com>; hotspot-compiler-
> dev at openjdk.java.net
> Cc: nd <nd at arm.com>; aarch64-port-dev at openjdk.java.net
> Subject: Re: [aarch64-port-dev ] RFR 8202186: AArch64: Debug build VM crashes
> with PrintC1Statistics option
> 
> On 04/27/2018 10:08 AM, Ningsheng Jian wrote:
> > I was thinking that the fix in incrementw may make this simple routine
> > require two scratch registers.
> 
> That's why you'd have to find check all of the callers.  You could even pass the
> scratch registers in as arguments, for ease of maintenance.
> 

Yes, I have checked and tested all the caller contexts. I forgot that original code
would use two scratch registers, if incremented by a large value. Since strw does not
support literal form, what about changing incrementw implementation like this?

http://cr.openjdk.java.net/~njian/8202186/webrev.02/

Thanks,
Ningsheng




More information about the hotspot-compiler-dev mailing list