RFR (XS) 8079682: [mlvm] remove SAM code in MHTransformationGen

Igor Ignatyev igor.ignatyev at oracle.com
Mon Aug 6 20:56:43 UTC 2018


JC,

as this fix is a trivial clean up, you don't need a second reviewer. I'll push your patch today.

-- Igor 

> On Aug 6, 2018, at 11:41 AM, JC Beyler <jcbeyler at google.com> wrote:
> 
> Thanks Igor,
> 
> Would anyone else on the list care to give me a review for this small webrev?
> 
> Thanks in advance!
> Jc
> 
> On Fri, Aug 3, 2018 at 2:44 PM Igor Ignatyev <igor.ignatyev at oracle.com <mailto:igor.ignatyev at oracle.com>> wrote:
> Hi Jc,
> 
> looks good to me.
> 
> -- Igor
> 
>> On Aug 3, 2018, at 2:32 PM, JC Beyler <jcbeyler at google.com <mailto:jcbeyler at google.com>> wrote:
>> 
>> Hi all,
>> 
>> I have a small webrev test fix for a MLVM test:
>> 
>> Webrev: http://cr.openjdk.java.net/~jcbeyler/8079682/webrev.00/ <http://cr.openjdk.java.net/~jcbeyler/8079682/webrev.00/>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8079682 <https://bugs.openjdk.java.net/browse/JDK-8079682>
>> 
>> Basically, I removed the case 9 of the switch, reduced the integer generation by 1 and shifted the cases 10 and 11.
>> 
>> I removed the case 9 and the MHSamTF object and class was not used anywhere else so I removed that as well (as per the bug).
>> 
>> Let me know what you think,
>> Jc
> 
> 
> 
> -- 
> 
> Thanks,
> Jc

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20180806/8f9ab009/attachment.html>


More information about the hotspot-compiler-dev mailing list