RFR (XS) 8204966: [TESTBUG] hotspot/test/compiler/whitebox/IsMethodCompilableTest.java test fails with -XX:CompileThreshold=1
Igor Ignatev
igor.ignatyev at oracle.com
Tue Aug 7 01:07:38 UTC 2018
You just need to label the bug w/ noreg-self and testbug to indicate that this is test only fix. No approvals needed, nor any jumping.
— Igor
> On Aug 6, 2018, at 6:04 PM, David Buck <david.buck at oracle.com> wrote:
>
> Hi Igor!
>
> Are there any additional approvals needed to push this to jdk11 [0] ATM? We're already in RDP2, but because this is a trivial testcase fix, maybe it would be allowed without jumping through any additional hoops?
>
> Cheers,
> -Buck
>
> [0] http://hg.openjdk.java.net/jdk/jdk11
>
> On 2018/08/07 9:50, Igor Ignatyev wrote:
>>> On Aug 6, 2018, at 5:47 PM, David Buck <david.buck at oracle.com> wrote:
>>>
>>>> which jdk repos are you going to push the fix?
>>>
>>> jdk/jdk and 8u-dev (after approval) are the only ones I had in mind ATM. Should I try to get it into anywhere else as well?
>> I'd like to see it fixed in jdk/jdk11, so I'd recommend to push it into jdk/jdk11 and it will be forward-ported automatically to jdk/jdk.
>> Thanks,
>> -- Igor
>>>
>>> Cheers,
>>> -Buck
>>>
>>>> On 2018/08/07 9:30, Igor Ignatyev wrote:
>>>> Hi David,
>>>> looks good to be.
>>>> which jdk repos are you going to push the fix?
>>>> Thanks,
>>>> -- Igor
>>>>> On Aug 4, 2018, at 4:26 AM, David Buck <david.buck at oracle.com> wrote:
>>>>>
>>>>> Hi!
>>>>>
>>>>> May I please get a review of this trivial fix to a testcase.
>>>>>
>>>>> bug report:
>>>>> https://bugs.openjdk.java.net/browse/JDK-8204966
>>>>>
>>>>> webrev
>>>>> http://cr.openjdk.java.net/~dbuck/8204966.0/
>>>>>
>>>>> Cheers,
>>>>> -Buck
More information about the hotspot-compiler-dev
mailing list