RFR: 8209439(XXS): C2 library_call can potentially ignore Math.pow intrinsic or use null pointer
Dmitrij Pochepko
dmitrij.pochepko at bell-sw.com
Mon Aug 13 18:42:30 UTC 2018
Thank you for review!
On 13/08/18 20:58, Vladimir Kozlov wrote:
> Looks good.
>
> Thanks,
> Vladimir
>
> On 8/13/18 10:44 AM, Dmitrij Pochepko wrote:
>> Hi,
>>
>> please review small fix for 8209439: C2 library_call can potentially
>> ignore Math.pow intrinsic or use null pointer
>>
>> During development of Math.pow intrinsic for AArch64 I noticed, that
>> this intrinsic is not used, so I found copy-paste error in library
>> calls. dexp existence is checked instead of dpow while trying to
>> inline Math.power.
>>
>> Currently no platform is affected because dexp and dpow either both
>> missing or exists.
>>
>> I've verified this fix by compiling jdk with my intrinsic and
>> checking vm behavior (on AArch64).
>>
>> CR: https://bugs.openjdk.java.net/browse/JDK-8209439
>>
>> webrev: http://cr.openjdk.java.net/~dpochepk/8209439/webrev.01/
>>
>>
>> Thanks,
>>
>> Dmitrij
>>
More information about the hotspot-compiler-dev
mailing list