RFR(XS) 8199885: [Graal] org.graalvm.compiler.core.test.CountedLoopTest fails with "ControlFlowAnchor should never be cloned in the same graph"

[Vladimir Kozlov]

Katya,

Did you confirmed that these tests are actually run in mach5 after these changes.
I see conflicting '@requires' in test definition:

   * @requires vm.opt.final.EnableJVMCI == true
+ * @requires !vm.graal.enabled

The only runs when EnableJVMCI is specified are runs with Graal as JIT in which case second 
@requires will skip tests.

May be move these test into a special group to make sure to run them without Graal JIT but with 
JVMCI on.

Thanks,
Vladimir

On 8/13/18 5:26 AM, Ekaterina Pavlova wrote:
> Hi All,
> 
> please review the change which disables org.graalvm.compiler.core.test.* tests in Graal as JIT mode.
> All these tests (except org.graalvm.compiler.core.test.tutorial.GraalTutorial and 
> org.graalvm.compiler.core.test.StaticInterfaceFieldTest)
> subclass GraalCompilerTest and were not designed to run in Graal as JIT mode.
> 
> Doug also confirmed that disabling org.graalvm.compiler.core.test.tutorial.GraalTutorial and 
> org.graalvm.compiler.core.test.StaticInterfaceFieldTest
> is also the right way.
> 
> Note, the tests will need to be modified/redesigned once Graal becomes default JIT compiler.
> 
> 
>      JBS: https://bugs.openjdk.java.net/browse/JDK-8199885
>   webrev: http://cr.openjdk.java.net/~epavlova//8199885/webrev.00/index.html
> testing: Run compiler/graalunit/CoreTest.java with enabled and disabled Graal. The test was skipped 
> in case Graal was enabled and
>           passed in case Graal was disabled.
> 
> thanks,
> -katya
> 
>