RFR: 8209439(XXS): C2 library_call can potentially ignore Math.pow intrinsic or use null pointer

[Dmitrij Pochepko]

Thank you for review.


On 14/08/18 09:16, Tobias Hartmann wrote:
> Hi Dmitrij,
>
> looks good to me too. Please request approval according to [1] if you want to get this into JDK 11.
>
> Thanks,
> Tobias
>
> [1] http://openjdk.java.net/jeps/3
>
>
> On 13.08.2018 20:42, Dmitrij Pochepko wrote:
>> Thank you for review!
>>
>>
>> On 13/08/18 20:58, Vladimir Kozlov wrote:
>>> Looks good.
>>>
>>> Thanks,
>>> Vladimir
>>>
>>> On 8/13/18 10:44 AM, Dmitrij Pochepko wrote:
>>>> Hi,
>>>>
>>>> please review small fix for  8209439: C2 library_call can potentially ignore Math.pow intrinsic
>>>> or use null pointer
>>>>
>>>> During development of Math.pow intrinsic for AArch64 I noticed, that this intrinsic is not used,
>>>> so I found copy-paste error in library calls. dexp existence is checked instead of dpow while
>>>> trying to inline Math.power.
>>>>
>>>> Currently no platform is affected because dexp and dpow either both missing or exists.
>>>>
>>>> I've verified this fix by compiling jdk with my intrinsic and checking vm behavior (on AArch64).
>>>>
>>>> CR: https://bugs.openjdk.java.net/browse/JDK-8209439
>>>>
>>>> webrev: http://cr.openjdk.java.net/~dpochepk/8209439/webrev.01/
>>>>
>>>>
>>>> Thanks,
>>>>
>>>> Dmitrij
>>>>