RFR(XS): JDK-8207746: C2: Lucene crashes on AVX512 instruction: Fix

Vladimir Kozlov vladimir.kozlov at oracle.com
Wed Aug 15 06:39:24 UTC 2018


Thank you, Tobias

webrev script "barfed" on these changes:

     patch cdiffs udiffs/usr/bin/awk: limited to 50 pat,pat statements at source line 56 source file /tmp/39719.file1
  context is
	NR==4445,NR==4446 >>> 	{changed();next} <<<

I think that is why webrev is broken. I don't know how to fix it.

Look on udiffs - they are correct:

http://cr.openjdk.java.net/~kvn/8207746/webrev.02/src/hotspot/cpu/x86/macroAssembler_x86.cpp.udiff.html

Vladimir

On 8/14/18 11:30 PM, Tobias Hartmann wrote:
> Hi,
> 
> On 15.08.2018 07:22, Vladimir Kozlov wrote:
>> To remove any other concerns about affects of using add/sub in macro instructions I decided to
>> replace all places where zmm register is saved/restored on stack:
>>
>> http://cr.openjdk.java.net/~kvn/8207746/webrev.02/
> 
> This looks good to me!
> 
> (There seems to be an issue with the webrev format though, the right side of the diffs is not shown:
> http://cr.openjdk.java.net/~kvn/8207746/webrev.02/src/hotspot/cpu/x86/macroAssembler_x86.cpp.sdiff.html)
> 
> Thanks,
> Tobias
> 


More information about the hotspot-compiler-dev mailing list