RFR: 8209535: [JVMCI] Do not swallow NoClassDefFoundError when converting JVMCI methods and fields to reflection objects.

Doug Simon doug.simon at oracle.com
Thu Aug 16 07:44:27 UTC 2018



> On 15 Aug 2018, at 18:38, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
> 
> Looks good to me.
> 
> I would suggest to run also hs-tier3-graal which tests Graal JIT.

I did and it caught a minor problem (now fixed) - thanks for the suggestion and review.

-Doug

> On 8/15/18 9:27 AM, Doug Simon wrote:
>> Hi,
>> Can I please get a review for this JVMCI bug fix (details in JBS issue).
>> The heart of the fix is in HotSpotResolvedJavaFieldImpl.java and HotSpotResolvedJavaMethodImpl.java.
>> All other changes are to bring the JVMCI code up to date with latest mx and to fix Eclipse warnings. I can leave these changes out if it is too much cleanup for one webrev.
>> Mach5 Testing: builds-tier1,hs-tier1
>> http://cr.openjdk.java.net/~dnsimon/8209535/
>> https://bugs.openjdk.java.net/browse/JDK-8209535
>> -Doug



More information about the hotspot-compiler-dev mailing list