RFR(XS): 8209588: SIGSEGV in MethodArityHistogram() with -XX:+CountCompiledCalls

[Schmidt, Lutz]

Thank you, Goetz!
Regards,
Lutz

On 20.08.18, 13:03, "Lindenmaier, Goetz" <goetz.lindenmaier at sap.com> wrote:

    Hi Lutz, 
    
    the change looks good. 
    
    All the checks using SafeFetch seem costly, but as I can see that's 
    nowhere performance relevant.  So it's acceptable for this code.
    
    Best regards,
      Goetz.
    
    > -----Original Message-----
    > From: hotspot-compiler-dev <hotspot-compiler-dev-
    > bounces at openjdk.java.net> On Behalf Of Schmidt, Lutz
    > Sent: Freitag, 17. August 2018 18:14
    > To: hotspot-compiler-dev at openjdk.java.net
    > Subject: [CAUTION] RFR(XS): 8209588: SIGSEGV in MethodArityHistogram()
    > with -XX:+CountCompiledCalls
    > 
    > Dear all,
    > 
    > 
    > 
    > may I please request reviews for this little change which prevents use of an
    > uninitialized pointer.
    > 
    > 
    > 
    > Bug:   https://bugs.openjdk.java.net/browse/JDK-8209588
    > <https://bugs.openjdk.java.net/browse/JDK-8209588>
    > 
    > Webrev: http://cr.openjdk.java.net/~lucy/webrevs/8209588.00/
    > <http://cr.openjdk.java.net/~lucy/webrevs/8209588.00/>
    > 
    > 
    > 
    > Thank you and enjoy your weekend!
    > 
    > Lutz
    > 
    > 
    > 
    >