[11] RTM tests fail
Christian Thalinger
cthalinger at twitter.com
Mon Aug 20 15:44:01 UTC 2018
> On Aug 20, 2018, at 5:02 PM, Lindenmaier, Goetz <goetz.lindenmaier at sap.com> wrote:
>
> Hi
>
> I think it would make more sense to add this in VMProps.java when
> vm.rtm.cpu is evaluated.
> Or to adapt the CPU feature string not to report rtm. While I think
> this is crude, I have seen (and then also done) this before.
>
> Adding !vm.graal.enabled to each test will require changing this
> in all tests when, e.g., RTM support is implemented in graal x86, but
> not in graal ppc …
Good point regarding different architectures.
>
> Best regards,
> Goetz.
>
>> -----Original Message-----
>> From: Christian Thalinger <cthalinger at twitter.com>
>> Sent: Montag, 20. August 2018 14:55
>> To: Gustavo Romero <gromero at linux.vnet.ibm.com>
>> Cc: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>; hotspot compiler
>> <hotspot-compiler-dev at openjdk.java.net>
>> Subject: Re: [11] RTM tests fail
>>
>> Quick additional question: Graal does not implement RTM (as far as I know)
>> but the tests are always run and I don’t see a:
>>
>> @requires !vm.graal.enabled
>>
>> in the test files. Should we add that?
>>
>>> On Jul 11, 2018, at 4:17 PM, Gustavo Romero
>> <gromero at linux.vnet.ibm.com> wrote:
>>>
>>> Hi Christian,
>>>
>>> On 07/11/2018 11:10 AM, Christian Thalinger wrote:
>>>>> On Jun 29, 2018, at 11:23 AM, Gustavo Romero
>> <gromero at linux.vnet.ibm.com> wrote:
>>>>>
>>>>> Hi Christian,
>>>>>
>>>>> On 06/29/2018 12:16 PM, Christian Thalinger wrote:
>>>>>>> On Jun 25, 2018, at 5:32 PM, Gustavo Romero
>> <gromero at linux.vnet.ibm.com <mailto:gromero at linux.vnet.ibm.com>>
>> wrote:
>>>>>>>
>>>>>>> Hi Christian,
>>>>>>>
>>>>>>> On 06/25/2018 09:54 AM, Christian Thalinger wrote:
>>>>>>>>> On Jun 25, 2018, at 8:49 AM, Gustavo Romero
>> <gromero at linux.vnet.ibm.com <mailto:gromero at linux.vnet.ibm.com>>
>> wrote:
>>>>>>>>>
>>>>>>>>> On 06/25/2018 09:46 AM, Lindenmaier, Goetz wrote:
>>>>>>>>>>>> Did you check with or without these fixes?
>>>>>>>>>>>
>>>>>>>>>>> Without, unfortunately. Are all of the failures fixed now (in jdk-
>> 11+19)?
>>>>>>>>>> I don't know, our machines do not have RTM, only our Power
>> ones do.
>>>>>>>>>> But I think Gustavo Romero from IBM claimed so.
>>>>>>>>>
>>>>>>>>> Yup, after the three fixes Goetz mentioned all RTM tests must pass
>> on Intel.
>>>>>>>> Ok, I’ll get back to you…
>>>>>>>
>>>>>>> Yes, please let me know if all went fine :)
>>>>>> I did not forget but we can’t merge in jdk-11+19 because of
>> https://bugs.openjdk.java.net/browse/JDK-8205616
>>>>>> We have to wait until jdk-11+20 is tagged.
>>>>>
>>>>> Sure!
>>>> I’m happy to report that all RTM test failures are fixed. Thanks!
>>> Thanks for testing & confirming it. :)
>>>
>>>
>>> Regards,
>>> Gustavo
>>>
>
More information about the hotspot-compiler-dev
mailing list