RFR: 8210066: [JVMCI] iterateFrames uses wrong GrowableArray API for appending

Doug Simon doug.simon at oracle.com
Fri Aug 31 09:43:34 UTC 2018


Thanks Chris.

I'm pushing the changes now.

-Doug

> On 31 Aug 2018, at 11:39, Christian Thalinger <cthalinger at twitter.com> wrote:
> 
> Looks good.
> 
>> On Aug 31, 2018, at 11:28 AM, Doug Simon <doug.simon at oracle.com> wrote:
>> 
>> Requesting one more review for this small change please.
>> 
>> -Doug
>> 
>>> On 29 Aug 2018, at 21:49, dean.long at oracle.com wrote:
>>> 
>>> Looks good!
>>> 
>>> dl
>>> 
>>> On 8/29/18 8:06 AM, Doug Simon wrote:
>>>> Please review this small patch to fix an incorrect usage of GrowableArray that can leads to an assertion failure in a fastdebug VM.
>>>> 
>>>> Many thanks to Gilles Duboscq for the test showing the problem and confirming that the fix works.
>>>> 
>>>> https://bugs.openjdk.java.net/browse/JDK-8210066
>>>> http://cr.openjdk.java.net/~dnsimon/8210066/
>>>> 
>>>> Testing: hs-tier3-graal
>>>> 
>>>> -Doug
>>> 
>> 
> 



More information about the hotspot-compiler-dev mailing list