RFR (XS): 8214526: Change CodeHeap State Analytics control from UL to Print*

[Thomas Stüfe]

+1

..Thomas
On Mon, Dec 3, 2018 at 5:49 PM Schmidt, Lutz <lutz.schmidt at sap.com> wrote:
>
> Hi,
> description in codeHeapState.cpp is adapted. In addition, I changed the name of the command line option to PrintCodeHeapAnalytics to better match the jcmd function name.
> New webrev is here: http://cr.openjdk.java.net/~lucy/webrevs/8214526.01/
> Thanks,
> Lutz
>
> On 03.12.18, 16:54, "Schmidt, Lutz" <lutz.schmidt at sap.com> wrote:
>
>     Oooohhh yes, good point.
>     Working on it...
>     Lutz
>
>     On 03.12.18, 16:44, "Vladimir Kozlov" <vladimir.kozlov at oracle.com> wrote:
>
>         Please, fix comments which describe usage in codeHeapState.cpp
>
>         Thanks,
>         Vladimir
>
>         On 12/3/18 3:42 AM, Schmidt, Lutz wrote:
>         > Hi Tobias, Thomas,
>         > thanks for the reviews. I decided to convert the switch to type "diagnostic" - that's what it is by nature. I have updated the webrev in-place.
>         > Thanks,
>         > Lutz
>         >
>         > On 03.12.18, 12:13, "Thomas Stüfe" <thomas.stuefe at gmail.com> wrote:
>         >
>         >      This makes much more sense than control via UL and mirrors what we do
>         >      with e.g. NMT. There, statistic printout is triggered by jcmd and with
>         >      -XX:+PrintNMTStatistics.
>         >
>         >      Change itself looks good. I guess you need either a CSR or make the
>         >      switch diagnostic (again, like PrintNMTStatistics).
>         >
>         >      ..Thomas
>         >      On Mon, Dec 3, 2018 at 11:41 AM Schmidt, Lutz <lutz.schmidt at sap.com> wrote:
>         >      >
>         >      > Hi all,
>         >      >
>         >      > may I please request reviews for this tiny change. It’s the result of lengthy discussions about which mechanism to use when printing large blocks of diagnostic information. In this case, output control is reverted from (ab)using UL back to a simple command line flag.
>         >      >
>         >      > Bug:    https://bugs.openjdk.java.net/browse/JDK-8214526
>         >      > Webrev: http://cr.openjdk.java.net/~lucy/webrevs/8214526.00/
>         >      >
>         >      > Thanks,
>         >      > Lutz
>         >      >
>         >      >
>         >
>         >
>
>
>
>