RFR(S) : 8214915 : CtwRunner misses export for jdk.internal.access

Vladimir Kozlov vladimir.kozlov at oracle.com
Thu Dec 6 02:41:55 UTC 2018


Looks good.

Thanks,
Vladimir

On 12/5/18 5:08 PM, Igor Ignatyev wrote:
> http://cr.openjdk.java.net/~iignatyev//8214915/webrev.00/index.html
>> 1 line changed: 1 ins; 0 del; 0 mod;
> 
> 
> Hi all,
> 
> could you please review this one-line fix for ctw testlibrary? working on other ctw bugs, I noticed that testing is too fast. it appears, that 8211122[1] moved SharedSecrets class, but CtwRunner doesn't add required export, so ctw tests were just loading classes, throwing IAE and weren't compiling anything. this patch fixes that, and I've also filed 8214917[2] to avoid similar problems being unnoticed.
> 
> [1] https://bugs.openjdk.java.net/browse/JDK-8211122
> [2] https://bugs.openjdk.java.net/browse/JDK-8214917
> 
> webrev: http://cr.openjdk.java.net/~iignatyev//8214915/webrev.00/index.html
> testing:
>   -:ctw_[1-3] on linux-x64
>   - grep for IllegalAccessError and '0 methods'
> JBS: https://bugs.openjdk.java.net/browse/JDK-8214915
> 
> Thanks,
> -- Igor
> 


More information about the hotspot-compiler-dev mailing list