RFR(XS): 8214912: LogCompilation: Show the comp level
Eric Caspole
eric.caspole at oracle.com
Thu Dec 6 18:36:16 UTC 2018
Doh, I will fix that before pushing.
After I get my new laptop set up I will fix the tests to work better to
check this stuff.
Eric
On 12/6/18 13:18, Igor Ignatyev wrote:
> now, it will print '0' as comp level in case of -Tiered, which isn't how PrintCompilation works, PrintCompilation doesn't print a comp level for -Tiered. not sure if it really has to be fixed, though. so it's up to you.
>
> LGTM.
>
> -- Igor
>
>> On Dec 6, 2018, at 8:24 AM, Eric Caspole <eric.caspole at oracle.com> wrote:
>>
>> I updated this to handle the -Tiered case and added new short test inputs for +/-Tiered:
>>
>> http://cr.openjdk.java.net/~ecaspole/JDK-8214912/02/webrev/
>>
>> Thanks,
>> Eric
>>
>>
>> On 12/6/18 09:48, Eric Caspole wrote:
>>> Good catch, thanks.
>>> On 12/5/18 18:57, Igor Ignatyev wrote:
>>>> Hi Eric,
>>>>
>>>> as -XX:-TieredCompilation runs won't have 'level' attribute, shouldn't you check if atts.getValue("level") isn't null?
>>>>
>>>> -- Igor
>>>>
>>>>> On Dec 5, 2018, at 3:51 PM, Eric Caspole <eric.caspole at oracle.com> wrote:
>>>>>
>>>>> Hi everybody,
>>>>> Could I have reviews on this small change to show the compilation level in the LogCompilation output similar to how it looks with +PrintCompilation, for example here the 3 is the level, after the id 606:
>>>>>
>>>>> 606 3 java.lang.Long::parseLong (267 bytes)
>>>>>
>>>>>
>>>>> Webrev:
>>>>> http://cr.openjdk.java.net/~ecaspole/JDK-8214912/webrev/
>>>>>
>>>>> JBS:
>>>>> https://bugs.openjdk.java.net/browse/JDK-8214912
>>>>>
>>>>> Thanks,
>>>>> Eric
>>>>
>
More information about the hotspot-compiler-dev
mailing list