RFR(XS): 8214376: Don't use memset to initialize array of Bundle in output.cpp

Dmitry Chuyko dmitry.chuyko at bell-sw.com
Fri Dec 7 14:47:40 UTC 2018


Yes, uint is used in code around and size_t is not.

Webrev with separated lines: 
http://cr.openjdk.java.net/~dchuyko/8214376/webrev.01/

-Dmitry

On 12/7/18 5:36 PM, Aleksey Shipilev wrote:
> On 12/7/18 3:29 PM, Aleksey Shipilev wrote:
>> On 12/7/18 2:32 PM, Dmitry Chuyko wrote:
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8214376
>>> webrev: http://cr.openjdk.java.net/~dchuyko/8214376/webrev.00/
>> Looks fine.
>>
>> I think we better break the lines:
>> 	
>>    for (uint i = 0; i < node_max; i++) {
>>       ::new (&_node_bundling_base[i]) Bundle();
>>    }
> Dang, indent is wrong, should be 2-space:
>
>   for (uint i = 0; i < node_max; i++) {
>     ::new (&_node_bundling_base[i]) Bundle();
>   }
>
> -Aleksey
>


More information about the hotspot-compiler-dev mailing list