[12] RFR(S) 8215317: [GRAAL] unit test CheckGraalIntrinsics failed after 8213754
dean.long at oracle.com
dean.long at oracle.com
Thu Dec 13 07:14:50 UTC 2018
Looks good.
dl
On 12/12/18 8:59 PM, Vladimir Kozlov wrote:
> The fix was reviewed by Igor V. and Tom R. in Graal's PR and pushed
> into Graal repo.
>
> Thanks,
> Vladimir
>
> On 12/12/18 8:10 PM, Vladimir Kozlov wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8215317
>>
>> JDK-8213754 added new intrinsics which cause Graal's unit test failure.
>>
>> CheckGraalIntrinsics test is adjusted for new intrinsics:
>>
>> src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/CheckGraalIntrinsics.java
>>
>> @@ -376,6 +376,14 @@
>> "jdk/jfr/internal/JVM.getEventWriter()Ljava/lang/Object;");
>> }
>>
>> + if (isJDK12OrHigher()) {
>> + add(toBeInvestigated,
>> + "java/lang/CharacterDataLatin1.isDigit(I)Z",
>> + "java/lang/CharacterDataLatin1.isLowerCase(I)Z",
>> + "java/lang/CharacterDataLatin1.isUpperCase(I)Z",
>> + "java/lang/CharacterDataLatin1.isWhitespace(I)Z");
>> + }
>> +
>> if (!config.inlineNotify()) {
>> add(ignore, "java/lang/Object.notify()V");
>> }
>>
>> Tested tier1 and tier3-graal (where test is run).
>>
>> I also pushed changes into Lab's Graal repo so this test will be
>> updated during next sync.
>> But I want to push fix into JDK because JDK 12 will be forked very soon.
>>
More information about the hotspot-compiler-dev
mailing list