RFR(S)[12] : 8215322 : add @file support to jaotc
Vladimir Kozlov
vladimir.kozlov at oracle.com
Fri Dec 14 05:37:12 UTC 2018
Good.
Thanks,
Vladimir
On 12/13/18 5:15 PM, Igor Ignatyev wrote:
> Hi Vladimir,
>
> thanks for review! sure, I've added the test: http://cr.openjdk.java.net/~iignatyev//8215322/webrev.0-1/test/hotspot/jtreg/compiler/aot/cli/jaotc/AtFileTest.java.html
>
> -- Igor
>
>> On Dec 13, 2018, at 4:52 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
>>
>> Looks good. Can you add small jtreg aot test to verify functionality?
>>
>> Thanks,
>> Vladimir
>>
>> On 12/13/18 4:29 PM, Igor Ignatyev wrote:
>>> http://cr.openjdk.java.net/~iignatyev//8215322/webrev.00
>>>> 33 lines changed: 30 ins; 2 del; 1 mod;
>>> Hi all,
>>> could you please review this patch for jatoc tool?
>>> from the bug:
>>> currently, the number of jaotc argument is limited by max command line length, in some cases, it isn't enough, for example compiling a number of selected classes. many java tools have support for '@file' so adding the same support to jaotc is natural and will solve the problem w/ limitation.
>>> I've requested approval per 'Late-Enhancement Request Process' from JEP 3 and will integrate it iif the approval is provided.
>>> webrev: http://cr.openjdk.java.net/~iignatyev//8215322/webrev.00
>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8215322
>>> testing: tier[1-2],hs-tier3-graal
>>> Thanks,
>>> -- Igor
>
More information about the hotspot-compiler-dev
mailing list