RFR: 8215500: ICRefillVerifierMark does not set the provided verfier as current

Erik Österlund erik.osterlund at oracle.com
Mon Dec 17 19:16:18 UTC 2018


Hi Per,

On 2018-12-17 19:12, Per Liden wrote:
> On 12/17/2018 06:57 PM, Erik Österlund wrote:
>> Hi,
>>
>> ICRefillVerifierMark::ICRefillVerifierMark sets "this" as the current 
>> verifier, as opposed to the verifier passed in. That is wrong.
>>
>> Bug:
>> https://bugs.openjdk.java.net/browse/JDK-8215500
>>
>> Webrev:
>> http://cr.openjdk.java.net/~eosterlund/8215500/webrev.00/
> 
> Wow, one of those "how could this have ever worked?" ;) Should we 
> forward declare ICRefillVerifier in thread.hpp to get some better type 
> safety here and avoid the reinterpret_cast in icBuffer.cpp?

Sure. New webrev:
http://cr.openjdk.java.net/~eosterlund/8215500/webrev.01/

Thanks,
/Erik

> cheers,
> Per


More information about the hotspot-compiler-dev mailing list