RFR: JDK-8197534: [TESTBUG] compiler/gcbarriers/PreserveFPRegistersTest.java fails with Conflicting collector combinations

Vaibhav Choudhary vaibhav.x.choudhary at oracle.com
Wed Feb 14 15:22:32 UTC 2018


Thank you again.

This issue is not a clean backport (mean to say “as it is”). There is a trivial change from 9 to 8u code, which is :-

In 8u, * @library /testlibrary /testlibrary/whitebox
In 9,  * @library /testlibrary /test/lib

Rest of the code is same.

Thanks,
Vaibhav Choudhary
vaibhav.x.choudhary at oracle.com
https://blogs.oracle.com/vaibhav



> On 14-Feb-2018, at 7:55 PM, Tobias Hartmann <tobias.hartmann at oracle.com> wrote:
> 
> Hi Vaibhav,
> 
> If the backport applies cleanly, you don't need a new review but request approval on jdk8u-dev according to:
> http://openjdk.java.net/projects/jdk8u/approval-template.html
> 
> You also don't need a new bug but the backport will be automatically created once you push with 8153194 as bug id.
> In this case, you can close 8197534 as duplicate of 8153194.
> 
> Thanks,
> Tobias
> 
> 
> On 14.02.2018 15:15, Vaibhav Choudhary wrote:
>> Thanks Tobias.
>> 
>> In that case, I need to change the scope of the bug. Here is the new webrev :-
>> 
>> http://cr.openjdk.java.net/~rpatil/8197534/webrev.01/
>> 
>> Thanks,
>> Vaibhav Choudhary
>> vaibhav.x.choudhary at oracle.com <mailto:vaibhav.x.choudhary at oracle.com>
>> https://blogs.oracle.com/vaibhav
>> 
>> 
>> 
>>> On 13-Feb-2018, at 2:50 PM, Tobias Hartmann <tobias.hartmann at oracle.com <mailto:tobias.hartmann at oracle.com>> wrote:
>>> 
>>> Hi Vaibhav,
>>> 
>>> You linked the wrong webrev. Here's the correct one:
>>> http://cr.openjdk.java.net/~rpatil/8197534/webrev.00
>>> 
>>> Wouldn't it make more sense to backport the full fix for JDK-8153194 [1]?
>>> 
>>> Thanks,
>>> Tobias
>>> 
>>> [1] https://bugs.openjdk.java.net/browse/JDK-8153194
>>> 
>>> 
>>> On 13.02.2018 09:49, Vaibhav Choudhary wrote:
>>>> Hi All,
>>>> Please review the fix for bug: https://bugs.openjdk.java.net/browse/JDK-8197534
>>>> Webrev: http://cr.openjdk.java.net/~rpatil/8197534/webrev.00/ <http://cr.openjdk.java.net/~rpatil/8141243/webrev.00>
>>>> 
>>>> Thanks,
>>>> Vaibhav C
>>>> 
>> 



More information about the hotspot-compiler-dev mailing list