RFR (XS): 8198703: Missing #include "gc/shared/cardTableModRefBS.hpp" in graphKit.hpp

Lindenmaier, Goetz goetz.lindenmaier at sap.com
Mon Feb 26 16:17:02 UTC 2018


Hi Eric, 

yes, that's the better solution.
Looks good.

Best regards,
  Goetz.

> -----Original Message-----
> From: Erik Österlund [mailto:erik.osterlund at oracle.com]
> Sent: Montag, 26. Februar 2018 17:11
> To: hotspot compiler <hotspot-compiler-dev at openjdk.java.net>; Lindenmaier,
> Goetz <goetz.lindenmaier at sap.com>
> Subject: RFR (XS): 8198703: Missing #include
> "gc/shared/cardTableModRefBS.hpp" in graphKit.hpp
> 
> Hi,
> 
> Please review this trivial fix. There is a missing include in
> graphKit.hpp to cardTableModRefBS.hpp used to check if reduce initial
> card marks should be used or not.
> 
> My solution is to simply move the implementation to the cpp file
> instead. I think the fix is trivial enough to only require one review.
> 
> Bug:
> https://bugs.openjdk.java.net/browse/JDK-8198703
> 
> Webrev:
> http://cr.openjdk.java.net/~eosterlund/8198703/webrev.00/
> 
> Thanks,
> /Erik


More information about the hotspot-compiler-dev mailing list