[11] RFR: 8198252: Null pointer dereference in fold_compares_helper

[Vladimir Kozlov]

+1

Vladimir

On 2/27/18 2:55 AM, Tobias Hartmann wrote:
> Hi Rahul,
> 
> looks good to me!
> 
> Best regards,
> Tobias
> 
> On 27.02.2018 11:37, Rahul Raghavan wrote:
>> Hi,
>>
>> Please review the following fix proposal.
>>
>> <webrev> - http://cr.openjdk.java.net/~rraghavan/8198252/webrev.01/
>>
>> <JBS> - https://bugs.openjdk.java.net/browse/JDK-8198252 -
>>    'Null pointer dereference in IfNode::fold_compares_helper'
>>
>> -- Reported issue is - filtered_int_type() may return NULL and
>> in IfNode::fold_compares_helper(), results of filtered_int_type() call - lo_type, hi_type - are
>> dereferenced without null checks.
>>
>> -- Proposed fix above is adding NULL check for required if conditions checks.
>>
>> -- Confirmed for other locations of calls to filtered_int_type(), the possible NULL result is handled.
>>
>>
>> Thanks,
>> Rahul