RFR(S) 8194271: jaotc crashes with --debug flag

Tobias Hartmann tobias.hartmann at oracle.com
Wed Jan 3 09:13:06 UTC 2018


Hi Igor,

the fix looks good to me. Should we add --debug to our testing?

Best regards,
Tobias

On 03.01.2018 07:02, Igor Veresov wrote:
> The change fixes the crash that occurs when jaotc tries to print method disassembly. The problem is that HotSpotCompiledCodeBuilder.createCompiledCode() assumes that if its method argument is null it’s a stub. And stub always has a name. The absence of a name caused the crash later on in the C++ code in CodeInstaller::install().
> 
> The solution is to pass method name to HotSpotCompiledCodeBuilder.createCompiledCode(). I also strengthened the C++ to throw an exception instead of crashing if a stub doesn’t have a name.
> 
> Webrev: http://cr.openjdk.java.net/~iveresov/8194271/webrev.00/
> JBS: https://bugs.openjdk.java.net/browse/JDK-8194271
> 
> 
> Thanks,
> igor
> 


More information about the hotspot-compiler-dev mailing list