RFR 11 (S): 8195069: LogCompilation - add basic unit tests

[Eric Caspole]

Thanks Chris, I have recently learned of JITWatch and I want to see how 
it complements or improves on the pretty basic LogCompilation.
Eric


On 01/18/2018 06:08 PM, Chris Newland wrote:
> Hi Eric, Vladimir,
> 
> Such tests would be really useful for JITWatch[1], especially if new unit
> tests are created when additional information is added to the
> LogCompilation output.
> 
> Kind regards,
> 
> Chris
> 
> [1] https://github.com/AdoptOpenJDK/jitwatch
> 
> On Thu, January 18, 2018 23:02, Vladimir Kozlov wrote:
>> Hi Eric,
>>
>>
>> Need more explanation about this. How you run the test?
>>
>>
>> Do you test LogCompilation functionality in JVM or the tool which parse
>> log file?
>>
>> If you want to test the tool why use pre-generated log files? You should
>> generate them with latest JVM.
>>
>> Thanks,
>> Vladimir
>>
>>
>> On 1/18/18 2:39 PM, Eric Caspole wrote:
>>
>>> Hi everybody,
>>> Could I have reviews for this change which adds very simple junits and
>>> more importantly the structure to add better ones later, to help prevent
>>>   bit rot in LogCompilation.
>>>
>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8195069
>>>
>>>
>>> Webrev: http://cr.openjdk.java.net/~ecaspole/JDK-8195069/webrev/
>>>
>>>
>>> Thanks,
>>> Eric
>>>
>>
>