RFR 11 (S): 8195069: LogCompilation - add basic unit tests

[Eric Caspole]

Thanks Vladimir, I added JDK-8196347 LogCompilation: generate log file 
on the fly for input to junits, to follow up later.

Anyone else - could I get one more reviewer for this one?
Thanks,
Eric


On 01/18/2018 06:50 PM, Vladimir Kozlov wrote:
> On 1/18/18 3:13 PM, Eric Caspole wrote:
>>
>> On 01/18/2018 06:02 PM, Vladimir Kozlov wrote:
>>> Hi Eric,
>>>
>>> Need more explanation about this. How you run the test?
>>
>> Hi Vladimir,
>>
>> The tests automatically run in the maven build process with "mvn clean 
>> install" for example. It is by convention where the tests are in 
>> src/test/java.
>>
>>>
>>> Do you test LogCompilation functionality in JVM or the tool which 
>>> parse log file?
>>>
>>> If you want to test the tool why use pre-generated log files? You 
>>> should generate them with latest JVM.
>>
>> Ideally we can generate the LogCompilation output on the fly in the 
>> build then analyze it, but just to set up the basic framework for 
>> future progress, here I just have it reading these small static files, 
>> to make sure there are no reportInternalError()'s happening like with 
>> JDK-8195064.
> 
> So it is first step. Okay. Please, file RFE to generate output on the fly.
> 
> Thanks,
> Vladimir
> 
>>
>> So this is a very primitive starter set for testing.
>> Eric
>>
>>>
>>> Thanks,
>>> Vladimir
>>>
>>> On 1/18/18 2:39 PM, Eric Caspole wrote:
>>>> Hi everybody,
>>>> Could I have reviews for this change which adds very simple junits 
>>>> and more importantly the structure to add better ones later, to help 
>>>> prevent bit rot in LogCompilation.
>>>>
>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8195069
>>>>
>>>> Webrev: http://cr.openjdk.java.net/~ecaspole/JDK-8195069/webrev/
>>>>
>>>> Thanks,
>>>> Eric