RFR(XXS): 8206113: Troubles configuring graal tests

[Igor Ignatyev]

> On Jul 2, 2018, at 3:52 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
> 
> On 7/2/18 3:28 PM, Igor Ignatyev wrote:
>> Vladimir,
>> there are two different configure-time problems:
>> - 1st is ability to get unbuildable configuration w/ AOT but w/o JVMCI
>>  - 2nd is not getting configure time warnings when Graal is enabled, but 3rd party libs aren't available for tests.
>> AFAIU,  8206135 is about 1st problem, and I, as David, expected 2nd problem to be addressed by 8206113. if you are planning to change the scope of 8206135, its title and descriptions should be changed correspondingly.
> 
> Yes, I talked only about 1st issue and I will fix only it.
> 
> What 3rd party libs you are you talking about?

Ones which are needed to compile/run graal unit tests[1]. JDK-8205207[2] added make/configure GRAALUNIT_LIB variable which is expected to point to the directory w/ these libraries and added compilations of graal unit tests part of 'test-image' target.

-- Igor

[1] test/hotspot/jtreg/compiler/graalunit/README.md:
 asm-5.0.4.jar
 asm-tree-5.0.4.jar
 junit-4.12.jar
 hamcrest-core-1.3.jar
 java-allocation-instrumenter.jar
[2] https://bugs.openjdk.java.net/browse/JDK-8205207 <https://bugs.openjdk.java.net/browse/JDK-8205207>

> 
> Thanks
> Vladimir
> 
>> Thanks,
>> -- Igor
>>> On Jul 2, 2018, at 2:19 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
>>> 
>>> On 7/2/18 2:17 PM, David Holmes wrote:
>>>> Hi Katya,
>>>> On 3/07/2018 5:10 AM, Ekaterina Pavlova wrote:
>>>>> Hi All,
>>>>> 
>>>>> please review this extra small change which makes make more silent by
>>>>> removing info message in case graal unit tests are not built.
>>>> Happy to see the build-time warning go, but I thought it was going to be replaced by some kind of configure-time warning?
>>> 
>>> I will fix it in jdk12:
>>> 
>>> JDK-8206135: Building jvm with AOT but without JVMCI should fail at configure time.
>>> 
>>> https://bugs.openjdk.java.net/browse/JDK-8206135
>>> 
>>> Vladimir
>>> 
>>>> Thanks,
>>>> David
>>>>>      JBS: https://bugs.openjdk.java.net/browse/JDK-8206113
>>>>>   webrev: http://cr.openjdk.java.net/~epavlova//8206113/webrev.00/index.html
>>>>> 
>>>>> thanks,
>>>>> -katya
>>>>> 
>>>>> p.s.
>>>>>   Igor Ignatyev volunteered to sponsor this change.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20180702/efa872db/attachment.html>