RFR (XS) 8206931: Misleading "COMPILE SKIPPED: invalid non-klass dependency" compile log

[Aleksey Shipilev]

Bug:
  https://bugs.openjdk.java.net/browse/JDK-8206931

It seems that JDK-8191052 made a misleading change:
  http://hg.openjdk.java.net/jdk/hs/rev/e8f5fc8f5f67

We used to print "invalid non-klass dependency" when we have detected the dependency that failed
is_klass_type() check. New code has Dependencies::validate_dependencies to reply with klass
dependency when SystemDictionary was changed and non-klass dependency when such dependency was
detected. But caller in ciEnv only prints "invalid non-klass dependency" when dependency _is_ the
klass dependency. jvmciEnv uses it inappropriately too, even though without observable effects.

Fix:
  http://cr.openjdk.java.net/~shade/8206931/webrev.01/

Testing: tier1_compiler, eyeballing compiler logs

Thanks,
-Aleksey

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20180710/6151ab06/signature-0001.asc>