RFR(XS): fix c2-only compilation and some tests

[Liu Xin]

hi, Vladimir,

Thank you for replying.

If I disable compiler1, I will run into compiler errors when I build
fastdebug. The attachment is the output.
Even if ignore the assertion, we still have problem to pass hs-tier1. it
will crash when it try to use jvmci.

Here is my configuration:
The existing configuration has been successfully updated in
/Users/xxinliu/Devel/openjdk/jdk/build/macosx-x86_64-normal-server-fastdebug
using configure arguments '--enable-option-checking=fatal
--with-debug-level=fastdebug --with-jtreg=/Users/xxinliu/Devel/jtreg
--with-jvm-features=-compiler1'.

Configuration summary:
* Debug level:    fastdebug
* HS debug level: fastdebug
* JVM variants:   server
* JVM features:   server: 'aot cds cmsgc compiler2 dtrace epsilongc g1gc
graal jfr jni-check jvmci jvmti management nmt parallelgc serialgc services
vm-structs'
* OpenJDK target: OS: macosx, CPU architecture: x86, address length: 64
* Version string: 12-internal+0-adhoc.xxinliu.jdk (12-internal)

thanks,
--lx

On Thu, Jul 26, 2018 at 12:48 PM, Vladimir Kozlov <
vladimir.kozlov at oracle.com> wrote:

> This does not seems right. What failure you got in aotCodeHeap.cpp and
> aotCompiledMethod.cpp?
>
> Thanks,
> Vladimir
>
> On 7/26/18 10:16 AM, Liu Xin wrote:
>
>> Hi, hotspot community,
>>
>>
>> Please review the small change to getc2-onlybuild to work.
>>
>> Bug:https://bugs.openjdk.java.net/browse/JDK-8207965
>>
>> Webrev: http://cr.openjdk.java.net/~phh/8207965/webrev.00/ <
>> http://cr.openjdk.java.net/%7Ephh/8207965/webrev.00/>
>>
>> It will meet 2 compiler errors if you configure project with “./configure
>> --with-jvm-features=-compiler1 --enable-option-checking=fatal
>> --with-debug-level=fastdebug”.
>>
>> the configure disable c1. Furthermore,  12 failures in hs-tier1 if we
>> havec2-only.
>>
>>
>> C2-onlybuilt met the following errors when I ran hs-tier1:
>>
>> compiler/aot/cli/jaotc/CompileClassWithDebugTest.java: check that jaotc
>> can compile a class with a --debug flag
>> compiler/jvmci/compilerToVM/IsCompilableTest.java:
>> compiler/jvmci/events/JvmciNotifyBootstrapFinishedEventTest.java:
>> compiler/jvmci/events/JvmciNotifyInstallEventTest.java:
>> compiler/jvmci/jdk.vm.ci.code.test/src/jdk/vm/ci/code/test/D
>> ataPatchTest.java:
>> compiler/jvmci/jdk.vm.ci.code.test/src/jdk/vm/ci/code/test/M
>> axOopMapStackOffsetTest.java:
>> compiler/jvmci/jdk.vm.ci.code.test/src/jdk/vm/ci/code/test/N
>> ativeCallTest.java:
>> compiler/jvmci/jdk.vm.ci.code.test/src/jdk/vm/ci/code/test/S
>> impleCodeInstallationTest.java:
>> compiler/jvmci/jdk.vm.ci.code.test/src/jdk/vm/ci/code/test/S
>> impleDebugInfoTest.java:
>> compiler/jvmci/jdk.vm.ci.code.test/src/jdk/vm/ci/code/test/V
>> irtualObjectDebugInfoTest.java:
>> compiler/types/TestMeetIncompatibleInterfaceArrays.java: C2 can not
>> handle returns with incompatible interface arrays
>>
>> Most due to bug similar withJDK-8145331 <https://bugs.openjdk.java.net
>> /browse/JDK-8145331>.
>>
>>
>> CompilerDirectives::get_for(AbstractCompiler *comp)  returns _/c1/_store
>>
>>   if jvmci() enabled, but hotspot won’t enable it if COMPILER1 is
>> disabled. As a result, hotspot messes up refcounts of _c1_store. This
>> webrev fixes 11 out of 12 cases.
>>
>>
>> The last test (compiler/types/TestMeetIncompatibleInterfaceArrays.java)
>> makes use of WhiteBox to check tier levels. I can’t fix it easily. Shall I
>> try to fix it in this webrev? If no, we can file a new bug to fix the test.
>> Does anyone have any idea how to fix it?
>>
>>
>> thanks,
>>
>> --lx
>>
>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20180726/3c072989/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: JDK-8207965.log.zip
Type: application/zip
Size: 1135 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20180726/3c072989/JDK-8207965.log.zip>