RFR (XS) 8191006: hsdis disassembler plugin does not compile with binutils 2.29+

[Andrew Dinn]

On 30/07/18 12:14, David Buck wrote:
> Please review this small fix to allow the hsdis plugin to be built
> against newer versions of binutils (>= 2.29).
> 
> bug report: https://bugs.openjdk.java.net/browse/JDK-8191006
> 
> webrev: http://cr.openjdk.java.net/~dbuck/8191006.0/
> 
> Note that this change will break support for building with older
> versions of binutils. (I am not aware of any reasonable use case for
> building hsdis against older versions of binutils. Please correct me if
> you are aware of any.) Also note that in addition to modifying the call
> to disassembler() to match the new signature, I also changed the include
> order of the header files. It seems that bfd.h now has a new dependency
> on string.h. I took this opportunity to better organize all of the
> includes.

Well, for various reasons I won't go into, I am in the sorry position of
having to build against a much older binutils (2.23!) on my current
AArch64 box. However, I suspect that is a rather special case and that I
can implement my own workaround.

regards,


Andrew Dinn
-----------
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander