RFR (XS) 8191006: hsdis disassembler plugin does not compile with binutils 2.29+

[Vladimir Kozlov]

I think switching to newer version of binutils is fine because the 
default version is now 2.30. I agree with fix.

Thanks,
Vladimir

On 7/30/18 4:14 AM, David Buck wrote:
> Hi!
> 
> Please review this small fix to allow the hsdis plugin to be built 
> against newer versions of binutils (>= 2.29).
> 
> bug report: https://bugs.openjdk.java.net/browse/JDK-8191006
> 
> webrev: http://cr.openjdk.java.net/~dbuck/8191006.0/
> 
> Note that this change will break support for building with older 
> versions of binutils. (I am not aware of any reasonable use case for 
> building hsdis against older versions of binutils. Please correct me if 
> you are aware of any.) Also note that in addition to modifying the call 
> to disassembler() to match the new signature, I also changed the include 
> order of the header files. It seems that bfd.h now has a new dependency 
> on string.h. I took this opportunity to better organize all of the 
> includes.
> 
> I kept the changes to the README file to a bare minimum as I hope to do 
> a more comprehensive doc update once a few other fixes [0] have been 
> pushed.
> 
> I have tested the new changes by building against binutils 2.29, 2.29.1, 
> 2.30, 2.31, and 2.31.1 on OL7 (amd64). I also built against binutils 
> 2.31.1 on Solaris 10 (SPARCv9) and Windows 10 / Cygwin (amd64).
> 
> Cheers,
> -Buck
> 
> [0] especially 8208495