RFR (XXS) 8208541: non-ASCII characters in hsdis UPL text
David Buck
david.buck at oracle.com
Tue Jul 31 05:29:51 UTC 2018
Hi Ao Qi!
Nice catch! I'll add it to 8191006 before I push that change (as it
already fixes a few typos in the README). Thanks!
Cheers,
-Buck
On 2018/07/31 14:12, Ao Qi wrote:
> Hi,
>
> Talking about hsdis/README, I recalled that there is a very small
> typo. I am not sure if it needs to be fixed.
>
> diff -r b5aac518b097 src/utils/hsdis/README
> --- a/src/utils/hsdis/README Mon Jul 30 16:35:54 2018 -0400
> +++ b/src/utils/hsdis/README Tue Jul 31 12:59:14 2018 +0800
> @@ -107,7 +107,7 @@
> the makefile what prefix to use to find the mingw tools by using
> MINGW=. For example:
>
> -make MINGW=i586-mingw32msvc BINTUILS=build/binutils-2.19.1
> +make MINGW=i586-mingw32msvc BINUTILS=build/binutils-2.19.1
>
> will build the Win32 cross compiled version of hsdis based on 2.19.1.
>
> Cheers,
> Ao Qi
> David Buck <david.buck at oracle.com> 于2018年7月31日周二 下午12:12写道:
>>
>> Hi!
>>
>> Please review this trivial fix to replace an unwieldy Unicode left/right
>> double quote pair with normal ASCII double quotes.
>>
>> bug report: https://bugs.openjdk.java.net/browse/JDK-8208541
>>
>> webrev: http://cr.openjdk.java.net/~dbuck/8208541.0/
>>
>> Sorry, I should have caught this earlier...
>>
>> Cheers,
>> -Buck
More information about the hotspot-compiler-dev
mailing list