RFR: 8189105: AARCH64: create intrinsic for sin and cos

Andrew Haley aph at redhat.com
Fri Jun 1 14:00:38 UTC 2018


On 06/01/2018 02:21 PM, Dmitrij Pochepko wrote:
> Also I launched respective JCK tests (api/java_lang/Math/sin* and 
> api/java_lang/Math/cos*) in both Xmixed and Xcomp modes
> 
> All passed, no failures found.
> 
> 
> webrev: http://cr.openjdk.java.net/~dpochepk/8189105/webrev.01/
> 
> CR: https://bugs.openjdk.java.net/browse/JDK-8189105

I don't really know how to review this.  It's a lot of hand-carved
assembly code and it's very hard to read.  It'd need to be very
thoroughly tested.

I hope you don't propose to rewrite the entire runtime library by
hand.  If you do, we need to have a proper discussion here about the
risk:reward ratio.

-- 
Andrew Haley
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671


More information about the hotspot-compiler-dev mailing list