RFR(S): 8204134: jtreg: Fix RTM abort provoker for various tests after "8149159: Clean up Unsafe" (Reviewed. Needs sponsor)

Gustavo Romero gromero at linux.vnet.ibm.com
Fri Jun 1 15:16:33 UTC 2018


Hi Igor, Vladimir,

On 05/31/2018 01:24 PM, Vladimir Kozlov wrote:
> On 5/30/18 8:34 PM, Igor Ignatyev wrote:
>> Hi Gustavo,
>>
>> looks good and trivial to me. thanks for fixing that.
> 
> +1

Thanks for reviewing.


Could somebody sponsor that change, please?


Best regards,
Gustavo

> Thanks,
> Vladimir
> 
>>
>> Cheers,
>> -- Igor
>>
>>> On May 30, 2018, at 7:04 PM, Gustavo Romero <gromero at linux.vnet.ibm.com> wrote:
>>>
>>> Hi,
>>>
>>> Could the following simple fix be reviewed please?
>>>
>>> webrev: http://cr.openjdk.java.net/~gromero/8204134/v1
>>> bug   : https://bugs.openjdk.java.net/browse/JDK-8204134
>>>
>>> Currently the following RTM tests are failing as change
>>> "8149159: Clean up Unsafe" made addressSize() method in Unsafe not native
>>> anymore:
>>>
>>> -FAILED: compiler/rtm/locking/TestRTMAbortRatio.java
>>> -FAILED: compiler/rtm/locking/TestRTMAbortThreshold.java
>>> -FAILED: compiler/rtm/locking/TestRTMAfterNonRTMDeopt.java
>>> -FAILED: compiler/rtm/locking/TestRTMDeoptOnHighAbortRatio.java
>>> -FAILED: compiler/rtm/locking/TestRTMDeoptOnLowAbortRatio.java
>>> -FAILED: compiler/rtm/locking/TestRTMLockingThreshold.java
>>> -FAILED: compiler/rtm/locking/TestUseRTMDeopt.java
>>> -FAILED: compiler/rtm/print/TestPrintPreciseRTMLockingStatistics.java
>>>
>>>
>>> Native methods are used as RTM abort provokers in the RTM jtreg test suite.
>>> As pageSize() method is still a native method replacing addressSize() by
>>> pageSize() fixes the issue:
>>>
>>> +Passed: compiler/rtm/locking/TestRTMAbortRatio.java
>>> +Passed: compiler/rtm/locking/TestRTMAbortThreshold.java
>>> +Passed: compiler/rtm/locking/TestRTMAfterNonRTMDeopt.java
>>> +Passed: compiler/rtm/locking/TestRTMDeoptOnHighAbortRatio.java
>>> +Passed: compiler/rtm/locking/TestRTMDeoptOnLowAbortRatio.java
>>> +Passed: compiler/rtm/locking/TestRTMLockingThreshold.java
>>> +Passed: compiler/rtm/locking/TestUseRTMDeopt.java
>>> +Passed: compiler/rtm/print/TestPrintPreciseRTMLockingStatistics.java
>>>
>>>
>>> Thank you.
>>>
>>> Best regards,
>>> Gustavo
>>>
>>
> 



More information about the hotspot-compiler-dev mailing list