RFR(XS): 8204277: [testbug] fix DisassembleCodeBlobTest.

Lindenmaier, Goetz goetz.lindenmaier at sap.com
Mon Jun 4 12:15:30 UTC 2018


Hi Tobias, 

thanks for reviewing. 
I fixed the typo.

Is this trivial enough to be pushed?

Best regards
  Goetz.

> -----Original Message-----
> From: Tobias Hartmann [mailto:tobias.hartmann at oracle.com]
> Sent: Montag, 4. Juni 2018 12:58
> To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>; hotspot-compiler-
> dev at openjdk.java.net
> Subject: Re: RFR(XS): 8204277: [testbug] fix DisassembleCodeBlobTest.
> 
> Hi Goetz,
> 
> looks good to me. Little typo: "veriy" -> "very".
> 
> Best regards,
> Tobias
> 
> On 04.06.2018 12:34, Lindenmaier, Goetz wrote:
> > Hi,
> >
> > this test fails because the first call to the disassembler prints the
> architecture:
> > [Disassembling for mach='i386:x86-64']
> >
> > Thus comparing the first and second result fails. Instead, compare 2. and 3.
> result.
> > http://cr.openjdk.java.net/~goetz/wr18/8204277-fixDisassTest/01/
> >
> > Best regards,
> >   Goetz.
> >


More information about the hotspot-compiler-dev mailing list