RFR (S) 8204237: Clean up incorrectly included .inline.hpp files from jvmciJavaClasses.hpp
coleen.phillimore at oracle.com
coleen.phillimore at oracle.com
Tue Jun 5 13:43:39 UTC 2018
Thank you for reviewing, Doug! I think this should merge fine with the
graal changes going in either direction.
Coleen
On 6/5/18 9:34 AM, Doug Simon wrote:
> The changes look ok to me.
>
> I don't think there's any need for an "up stream" push Vladimir as these are only JVMCI changes, not Graal changes.
>
> -Doug
>
>> On 4 Jun 2018, at 20:41, coleen.phillimore at oracle.com wrote:
>>
>>
>> Thanks Vladimir and for including the graal-dev mailing list.
>> Coleen
>>
>> On 6/4/18 1:38 PM, Vladimir Kozlov wrote:
>>> Looks good to me.
>>>
>>> We need review from Labs and push it up-stream to Lab's jvmci repo.
>>>
>>> Thanks,
>>> Vladimir
>>>
>>> On 6/4/18 10:12 AM, coleen.phillimore at oracle.com wrote:
>>>> Summary: Reexpand macro to provide non-inline functions.
>>>>
>>>> open webrev at http://cr.openjdk.java.net/~coleenp/8204237.01/webrev
>>>> bug link https://bugs.openjdk.java.net/browse/JDK-8204237
>>>>
>>>> Ran mach5 hs-tier1-2 on 4 Oracle platforms. There are no target-dependent changes.
>>>>
>>>> Thanks,
>>>> Coleen
More information about the hotspot-compiler-dev
mailing list