RFR(XS) : 8204577 : jittester generator doesn't kill processes on timeout

[Vladimir Kozlov]

+1

Vladimir K

On 6/7/18 3:04 PM, Ekaterina Pavlova wrote:
> Looks good.
> 
> -katya
> 
> On 6/7/18 2:17 PM, Igor Ignatyev wrote:
>> http://cr.openjdk.java.net/~iignatyev//8204577/webrev.00
>>> 11 lines changed: 5 ins; 2 del; 4 mod;
>>
>> Hi all,
>>
>> could you please review this small fix for jit-tester test generator?
>>
>> TestsGenerator::generateGoldenOut starts a new process to get golden output, waits for a process 
>> to finish Automatic.MINUTES_TO_WAIT and destroys it afterward. however Automatic::main interrupts 
>> generatorThread (the thread which runs TestsGenerator::runProcess) after 
>> Automatic.MINUTES_TO_WAIT, so we get an interrupted exception and don't destroy the process.
>>
>> the patch changes wait time to default jtreg timeout (120 seconds) and also moves 
>> Process::destroyForcibly to finally block.
>>
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8204577
>> webrev: http://cr.openjdk.java.net/~iignatyev//8204577/webrev.00
>> testing: compiled jit-tester library and generate a number of tests w/ it
>>
>> Thanks,
>> -- Igor
>>
>