RFR(M): 8205207: Port Graal unit tests under jtreg
Vladimir Kozlov
vladimir.kozlov at oracle.com
Tue Jun 19 15:23:29 UTC 2018
Hi Katya,
Please, fix Copyright year in new files:
test/hotspot/jtreg/compiler/graalunit/com.oracle.mxtool.junit/com/oracle/mxtool/junit/*
Thanks,
Vladimir
On 6/18/18 10:26 PM, Ekaterina Pavlova wrote:
> Hi All,
>
> please review porting of Graal unit tests under jtreg. The main idea of
> this porting is to keep Graal unit tests as is
> (located in src/jdk.internal.vm.compiler/share/classes/*.test) and run
> them similar way they are run in Graal project.
> To achieve this
> test/hotspot/jtreg/compiler/graalunit/common/GraalUnitTestLauncher.java
> helper class has been written
> which simply launches com.oracle.mxtool.junit.MxJUnitWrapper to run
> specified set of Graal unit tests. The groups of
> Graal unit tests to run are defined in auto-generated
> test/hotspot/jtreg/compiler/graalunit/*.java jtreg tests.
>
> New make/test/JtregGraalUnit.gmk is used to build Graal unit tests into
> jdk.vm.compiler.tests.jar and then install
> it in $(TEST_IMAGE_DIR)/hotspot/jtreg/graal/.
>
> make/Main.gmk adds proper dependencies for
> build-test-hotspot-jtreg-graal and test-image-hotspot-jtreg-graal.
>
> test/TestCommon.gmk passes TEST_IMAGE_GRAAL_DIR to jtreg so jtreg knows
> where to find Graal tests and libs.
>
> test/hotspot/jtreg/compiler/graalunit/TestPackages.txt file defines
> "testName -> testPrefix [requiresStatement]" mapping
> which is used by test/hotspot/jtreg/compiler/graalunit/generateTests.sh
> script to generate jtreg tests.
>
> test/hotspot/jtreg/compiler/graalunit/com.oracle.mxtool.junit was ported
> from mx project without any changes.
>
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8205207
> webrev:
> http://cr.openjdk.java.net/~epavlova//8205207/webrev.00/index.html
> testing: new tests were executed as part of automatic HS testing for
> several months.
>
>
> thanks,
> -katya
>
> p.s.
> Igor Ignatyev volunteered to sponsor this change.
More information about the hotspot-compiler-dev
mailing list