[aarch64-port-dev ] RFR: 8204289: AARCH64: enable math intrinsics usage in interpreter and C1

[Dmitrij Pochepko]

Hi Derek, Andrew,

Here is an updated version with your comments addressed: 
http://cr.openjdk.java.net/~dpochepk/8204289/webrev.03/

Thanks,

Dmitrij


On 22.06.2018 04:40, White, Derek wrote:
> Hi Dmitrij,
>
> There's some bad indenting in c1_LIRGenerator_aarch64.cpp around lines
> 815, 828, 829, 849, 850.
>
> I didn't follow all of the differences between the change from call_runtime to __ call_runtime_leaf, (although I see that it follows the x86 code.) So I wouldn't call this a full review.
>
> Thanks,
> - Derek
>
>> -----Original Message-----
>> From: aarch64-port-dev [mailto:aarch64-port-dev-
>> bounces at openjdk.java.net] On Behalf Of Dmitrij Pochepko
>> Sent: Wednesday, June 20, 2018 10:45 AM
>> To: aarch64-port-dev at openjdk.java.net; hotspot-compiler-
>> dev at openjdk.java.net
>> Subject: Re: [aarch64-port-dev ] RFR: 8204289: AARCH64: enable math
>> intrinsics usage in interpreter and C1
>>
>> External Email
>>
>> Hi,
>>
>>
>> can somebody take a look?
>>
>>
>> Thanks,
>>
>> Dmitrij
>>
>>
>> On 04.06.2018 18:50, Dmitrij Pochepko wrote:
>>> Hi all,
>>>
>>> please review patch for JDK-8204289: AARCH64: enable math intrinsics
>>> usage in interpreter and C1
>>>
>>> This patch enables usage of math intrinsics for interpreter and C1 in
>>> case intrinsics are implemented. Code follows that of x86 port.
>>>
>>>
>>> Testing: I've merged this patch with implemented intrinsic and
>>> launched jtreg tests and benchmark in 2 more modes: -Xint and
>>> -XX:TieredStopAtLevel=3
>>>
>>> Benchmark scores were improved as expected of intrinsic. All tests
>>> passed.
>>>
>>>
>>> webrev: http://cr.openjdk.java.net/~dpochepk/8204289/webrev.01/
>>>
>>> CR: https://bugs.openjdk.java.net/browse/JDK-8204289
>>>
>>>
>>> Thanks,
>>>
>>> Dmitrij
>>>