RFR(S) : 8160673 : Jittester: investigate bytecode generation hangs during bytecode tests generation

[Igor Ignatyev]

Hi Igor,

thanks for your review.
-- Igor

> On Jun 27, 2018, at 4:39 PM, Igor Veresov <igor.veresov at oracle.com> wrote:
> 
> Looks fine.
> 
> igor
> 
>> On Jun 26, 2018, at 4:21 PM, Igor Ignatyev <igor.ignatyev at oracle.com> wrote:
>> 
>> http://cr.openjdk.java.net/~iignatyev//8160673/webrev.00/index.html
>>> 32 lines changed: 6 ins; 12 del; 14 mod; 
>> 
>> Hi all,
>> 
>> could you please review this small fix for jit-tester library?
>> 
>> ByteCodeVisitor loaded generated classes, so ContextDependedClassWriter::getCommonSuperClass would be able to find common supper class using regular Class methods. in some cases, bytrecode for classes isn't yet generated (and hence not loaded) when getCommonSuperClass needs to get information about them (e.g. when generating bytecode for Class1 which is using instances of Class2 and a super class of Class2), which resulted in infinity loop inside asm library.
>> 
>> the fix changes getCommonSuperClass method to use information about classes from jit-tester maintained list of all generated and used types.
>> 
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8160673
>> webrev: http://cr.openjdk.java.net/~iignatyev//8160673/webrev.00/index.html
>> testing: generated 1k tests w/ jit-tester
>> 
>> Thanks,
>> -- Igor
>