RFR(L) 8205824: Update Graal

Tom Rodriguez tom.rodriguez at oracle.com
Fri Jun 29 18:28:58 UTC 2018


>> 8204855 is a set of changes to the JVMCI API which are required to 
>> support the libgraal effort.  Primarily this is about making a strong 
>> distinction between runtime and compiler objects and state and hiding 
>> anything which lets you bridge that boundary without be careful. 
>> Mostly it doesn't change the way JVMCI works apart from some changes 
>> to the HotSpotSpeculationLog implementation and the associated changes 
>> in Graal.  These changes are binary incompatible with previous 
>> versions of JVMCI.  Given the limitations of webrev I can't easily 
>> provide a webrev which shows just this change.
> 
> There have been several examples of incremental webrevs for large 
> changes recently. It's impossible to have an opinion on the jvmci 
> changes given this webrev.

I would have preferred to have a simpler webrev for review.  Originally 
this change was going to be just the JVMCI API update but at the last 
minute a full Graal update was added on top so I wasn't able to do that. 
  Given the single changeset requirements of pushes it wasn't really 
possible to keep them separate anymore.  Single commit pushes and webrev 
don't make it easy to provide a good reviewing experience for complex 
changes.

The changes to jdk.vm.ci are the JVMCI API update itself so it's only 
the adjustments required by Graal for the API that are mixed in with 
other Graal updates.  A slightly out of date webrev of the original 
change is at http://cr.openjdk.java.net/~never/8204855/webrev if you 
wish to see those.  They are generally speaking fairly trivial.  They 
will also be directly visible as a merge changeset in the Graal sources 
when those changes officially land, probably on Monday.

tom

> 
> // Nils
> 
>>
>> The bits were tested with mach5 
>> builds-tier1,jdk-tier1,hs-tier1,hs-tier2,hs-tier3,hs-tier4-graal,hs-tier5-graal 
>> and hs-tier6-graal.  The details are in the bug report.
>>
>> I'm happy to explain anything about changes the JVMCI and why they 
>> were required.  The JVMCI API updates have been tested with JDK8 Graal 
>> and will land in the next few days.
>>
>> tom
> 


More information about the hotspot-compiler-dev mailing list